(PCP-208) ThreadContainer associates names to threads #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2016 15:41
Deleting also the copy assignment.
When adding a thread objecty to a ThreadContainer instance, the user must also specify the name of the thread. This enables inspection. Using an unsorted_map instead of a vector to store the thread instances; this enables the retrieval by name. Raising an Error in case ThreadContainer::add is called for an existent name. Adding find() and getThreadNames() methods. Making const member functions where possible. Adding new unit tests. Updating RequestProcessor to comply with the new interface and with the possibility of having stored a thread with the same name (using a mutex for that). For a given non-blocking request, it's execution thread will be named against the transaction_id.
| ThreadContainer(const std::string& name = "", | ||
| uint32_t _check_interval = THREADS_MONITORING_INTERVAL_MS, | ||
| uint32_t _threads_threshold = THREADS_THRESHOLD); | ||
| ThreadContainer(const ThreadContainer&) = delete; | ||
| ThreadContainer& operator=(const ThreadContainer&) = delete; |
There was a problem hiding this comment.
Why are you disabling the constructors (and the = operator)?
There was a problem hiding this comment.
For the rule of 3 plus threads are not copiable.
|
LGTM |
mruzicka
added a commit
that referenced
this pull request
Feb 4, 2016
(PCP-208) ThreadContainer associates names to threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.